Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes based on feedback #39

Merged
merged 2 commits into from
Aug 7, 2024
Merged

fixes based on feedback #39

merged 2 commits into from
Aug 7, 2024

Conversation

stevenplewis
Copy link
Collaborator

No description provided.

vladh
vladh requested changes Aug 5, 2024
View reviewed changes
Copy link
Member

@vladh vladh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CTA is overflowing and causing horizontal scroll on mobile.

2024-08-05-20-21-40
IMG_6855

Could we break it up on mobile?

Easy fix:

.footer-cta-box {
  flex-wrap: wrap;
  justify-content: center;
}

@vladh vladh merged commit 395aef1 into main Aug 7, 2024
1 check passed
@vladh vladh deleted the sl/first-branding-pass-patches branch August 7, 2024 09:04
@vladh
Copy link
Member

vladh commented Aug 7, 2024

@stevenplewis @chadwhitacre I fixed this and merged because I need these changes, hope that's okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladh vladh vladh requested changes

@chadwhitacre chadwhitacre Awaiting requested review from chadwhitacre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@stevenplewis @vladh